From 7b41618f5a08145b0198af4a8a2ce361d7e677e6 Mon Sep 17 00:00:00 2001 From: Julien Grall Date: Fri, 25 Jul 2014 15:17:26 +0100 Subject: [PATCH] xen/arm: domain_vgic_init: Avoid double free on shared_irqs When the function domain_vgic_init is failing to initialize pending_irqs, it will free shared_irqs. Few call later, domain_vgic_free will be called an try to free a second time the same variable. This will result to a double free. Remove the free in domain_vgic_init and rely on domain_vgic_free to correctly release the memory. Signed-off-by: Julien Grall Acked-by: Ian Campbell --- xen/arch/arm/vgic.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c index 6b41dbfe0f..1372ffc994 100644 --- a/xen/arch/arm/vgic.c +++ b/xen/arch/arm/vgic.c @@ -85,10 +85,7 @@ int domain_vgic_init(struct domain *d) d->arch.vgic.pending_irqs = xzalloc_array(struct pending_irq, d->arch.vgic.nr_lines); if ( d->arch.vgic.pending_irqs == NULL ) - { - xfree(d->arch.vgic.shared_irqs); return -ENOMEM; - } for (i=0; iarch.vgic.nr_lines; i++) { -- 2.30.2